Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.7.x] Fix securityProtocol sasl config in consumer #106

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

gajosu
Copy link
Contributor

@gajosu gajosu commented Jun 3, 2022

Hi, I'm testing the package with a Sasl connection and in the consumer builder, when the securityProtocol setting is specified, argument 4 of the Sasl class is not taken into account, so the only way to make it work is to use the withSecurityProtocol. method, this PR solves the problem

@gajosu gajosu changed the title [v1.7.x] Fix securityProtocol sasl config in consummer [v1.7.x] Fix securityProtocol sasl config in consumer Jun 3, 2022
@iprastha
Copy link

iprastha commented Jun 3, 2022

Hi i'm having this issue as well, and obtained the following error

Disconnected: verify that security.protocol is correctly configured, broker might require SASL authentication

If this is not merged yet, means when building the consumer , i should add the following

->withSecurityProtocol('SASL_PLAINTEXT')

is this correct ?

@mateusjunges
Copy link
Owner

mateusjunges commented Jun 3, 2022

Thank you @gajosu. Just a quick note: with this method, the protocol defined in the sasl config takes priority over withSecurityProtocol method.

Hi i'm having this issue as well, and obtained the following error

Disconnected: verify that security.protocol is correctly configured, broker might require SASL authentication

If this is not merged yet, means when building the consumer , i should add the following

->withSecurityProtocol('SASL_PLAINTEXT')

is this correct ?

Yes

@gajosu
Copy link
Contributor Author

gajosu commented Jun 3, 2022

Thank you @gajosu. Just a quick note: with this method, the protocol defined in the sasl config takes priority over withSecurityProtocol method.

Hello, yes, if the ->withSasl() method is set, it will have priority, because in the Sasl class it already defines a security protocol

@mateusjunges mateusjunges merged commit 731375f into mateusjunges:v1.7.x Jun 3, 2022
@mateusjunges
Copy link
Owner

@gajosu @iprastha just released this fix on v1.7.7. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants