Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple filters can not be submitted on bs_smart_collection #7

Open
jonasjabari opened this issue Apr 28, 2021 · 2 comments
Open

Multiple filters can not be submitted on bs_smart_collection #7

jonasjabari opened this issue Apr 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working smart_collection

Comments

@jonasjabari
Copy link
Member

If more than one filter is applied to bs_smart_collection, the filters are not submitted on ENTER as it's happening when only applying one filter

@jonasjabari jonasjabari added bug Something isn't working smart_collection labels Apr 28, 2021
gitbook-com bot pushed a commit that referenced this issue Jun 6, 2022
@aaron-contreras
Copy link
Member

This is still an open issue and present in version 3+. Can I assign this to myself and work on it? @keithrowell @jonasjabari

I've actually developed a fix/workaround for this in a client project and can port it over to the gem. The W3C spec explains that this is natural behavior of forms:

Form Submission

...
...

When there is only one single-line text input field in a form, the user agent should accept Enter in that field as a request to submit the form.

A Stackoverflow question was also asked about this and the accepted answer directed to the above section of the W3C spec.

@jonasjabari
Copy link
Member Author

@aaron-contreras yes please assign it to yourself and have fun working on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart_collection
Projects
None yet
Development

No branches or pull requests

3 participants