Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly Support #195

Merged
merged 16 commits into from
May 21, 2024
Merged

Plotly Support #195

merged 16 commits into from
May 21, 2024

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented May 21, 2024

Added Plotly support to help integrate with MP website.

Major changes:

  • Added Plotly support to help integrate with MP website
  • Added tests for plotting

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 90.75630% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 90.88%. Comparing base (4f75202) to head (1d155ea).
Report is 7 commits behind head on main.

Files Patch % Lines
pymatgen/analysis/defects/plotting/thermo.py 90.90% 5 Missing and 4 partials ⚠️
pymatgen/analysis/defects/plotting/utils.py 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   90.90%   90.88%   -0.02%     
==========================================
  Files          11       13       +2     
  Lines        2110     2227     +117     
  Branches      393      410      +17     
==========================================
+ Hits         1918     2024     +106     
- Misses        111      116       +5     
- Partials       81       87       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plot tests

plot tests

plot tests

plot tests
@jmmshn jmmshn self-assigned this May 21, 2024
@jmmshn jmmshn merged commit 8a44d47 into main May 21, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant