Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with last_updated in MapBuilder #98

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Fix issues with last_updated in MapBuilder #98

merged 4 commits into from
Feb 17, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Feb 13, 2020

This PR fixes some issues with the treatment of last_updated in the core store and MapBuilder

  • make newer_in more resilient to lack of last_updated fields
  • fix typos in MultiplyBuilder example

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files          20       20           
  Lines        1453     1453           
=======================================
  Hits         1267     1267           
  Misses        186      186
Impacted Files Coverage Δ
src/maggma/core/store.py 87.23% <ø> (ø) ⬆️
src/maggma/builders/map_builder.py 91.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1c09f...e985114. Read the comment docs.

@shyamd shyamd merged commit 82483d6 into master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant