Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move API to optional dependency group; move OpenData to default installation #970

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

rkingsbury
Copy link
Collaborator

@rkingsbury rkingsbury commented Jun 20, 2024

WIP changes to dependency setup; checking impact on CI tests. See #928 .

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (57fb676) to head (5bb459c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #970   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files          46       46           
  Lines        3981     3981           
=======================================
  Hits         3534     3534           
  Misses        447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury self-assigned this Jun 20, 2024
@rkingsbury rkingsbury merged commit 5bb459c into materialsproject:main Jun 20, 2024
9 checks passed
@rkingsbury
Copy link
Collaborator Author

Sorry all, I did not intend to merge this yet. (Perils of using GitHub on my phone!) I'll revert if @munrojm objects to these changes. It hasn't been released so shouldn't affect any users yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant