Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dask support to mrun #927

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Adding Dask support to mrun #927

wants to merge 17 commits into from

Conversation

tsmathis
Copy link
Collaborator

Summary

Major changes:

added a Dask work broker for use with mrun

Todos

  • test run a builder on a distributed cluster
  • add documentation for the differences needed to write Dask-compatible builders

Checklist

  • Google format doc strings added.
  • Code linted with ruff. (For guidance in fixing rule violates, see rule list)
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • I have run the tests locally and they passed.

src/maggma/cli/__init__.py Fixed Show fixed Hide fixed
@@ -214,6 +286,18 @@
)
else:
worker(url=url, port=port, num_processes=num_processes, no_bars=no_bars)
elif dask:
dask_executor(

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error

Local variable 'dask_executor' may be used before it is initialized.
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 25.37313% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 80.58%. Comparing base (53867d9) to head (245cf3e).
Report is 9 commits behind head on main.

Files Patch % Lines
src/maggma/cli/dask_executor.py 0.00% 47 Missing ⚠️
src/maggma/cli/__init__.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   81.56%   80.58%   -0.99%     
==========================================
  Files          46       47       +1     
  Lines        3938     4007      +69     
==========================================
+ Hits         3212     3229      +17     
- Misses        726      778      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant