Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distinct to be more like mongo distinct #92

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Update distinct to be more like mongo distinct #92

merged 5 commits into from
Jan 28, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jan 28, 2020

This PR updates distinct to be more like mongo's distinct. It primarily removes the multi-field distinct.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #92 into master will decrease coverage by 0.1%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   87.07%   86.97%   -0.11%     
==========================================
  Files          20       20              
  Lines        1447     1443       -4     
==========================================
- Hits         1260     1255       -5     
- Misses        187      188       +1
Impacted Files Coverage Δ
src/maggma/stores/aws.py 76.41% <0%> (ø) ⬆️
src/maggma/stores/mongolike.py 93.71% <100%> (-0.48%) ⬇️
src/maggma/stores/gridfs.py 84.37% <100%> (-0.13%) ⬇️
src/maggma/stores/compound_stores.py 80.79% <100%> (+0.34%) ⬆️
src/maggma/core/store.py 87.23% <100%> (-0.53%) ⬇️
src/maggma/stores/advanced_stores.py 80.55% <66.66%> (-0.56%) ⬇️
src/maggma/builders/group_builder.py 85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78fac4b...e3a1a31. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2020

This pull request introduces 1 alert when merging 60de246 into 5d1b7fc - view on LGTM.com

new alerts:

  • 1 for First argument to super() is not enclosing class

@shyamd shyamd merged commit 98642b8 into master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant