Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating for open data format change #911

Merged

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Feb 2, 2024

Summary

Updating the OpenDataStore to work with the changes in the format for storing the data in Open Data.

Checklist

  • Google format doc strings added.
  • Code linted with ruff. (For guidance in fixing rule violates, see rule list)
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • I have run the tests locally and they passed.

src/maggma/stores/open_data.py Fixed Show resolved Hide resolved
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (5bd33b3) 82.98% compared to head (6baf8bc) 81.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/maggma/stores/open_data.py 0.00% 108 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   82.98%   81.54%   -1.44%     
==========================================
  Files          46       46              
  Lines        3878     3939      +61     
==========================================
- Hits         3218     3212       -6     
- Misses        660      727      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit efb4b2b into materialsproject:main Feb 2, 2024
8 of 10 checks passed
@kbuma kbuma deleted the enhancement/open_data_format_update branch September 9, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants