Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic model reference #869

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Remove generic model reference #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/maggma/api/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from typing import Generic, List, Optional, TypeVar

from pydantic import BaseModel, Field, validator
from pydantic.generics import GenericModel

from maggma import __version__

Expand Down Expand Up @@ -47,7 +46,7 @@ def from_traceback(cls, traceback):
pass


class Response(GenericModel, Generic[DataT]):
class Response(BaseModel, Generic[DataT]):
"""
A Generic API Response
"""
Expand Down