Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI pipeline so repeated commits don't cause concurrent tests #850

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Aug 30, 2023

I updated the CI pipeline such that if multiple commits have been made in relatively quick succession, the prior commit's in progress tests will be cancelled. Since the maggma tests take a fair bit of time, this is a nice convenience feature in my opinion.

I also updated the classifier for the production status to "Development Status :: 5 - Production/Stable" and added a missing src line in the ruff spec for pyproject.toml.

Note: I first learned about this from repo-review and have been using it for all my projects. You might be interested in some of the items flagged for maggma, although a fair number of them are quite subjective.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Update CI pipeline so repeated commits don't cause redundant tests Update CI pipeline so repeated commits don't cause concurrent tests Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7353e57) 88.14% compared to head (1c880c5) 88.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          44       44           
  Lines        3593     3593           
=======================================
  Hits         3167     3167           
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury
Copy link
Collaborator

Good stuff, thank you @arosen93 ! I will be making use of repo-review 😄

@rkingsbury rkingsbury merged commit dba6f4c into materialsproject:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants