JSONStore: enabled reading of MongoDB extended JSON files #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 44 44
Lines 3592 3593 +1
=======================================
+ Hits 3166 3167 +1
Misses 426 426
☔ View full report in Codecov by Sentry. |
|
Flagging @arosen93 as well for any comments |
|
No comments from me here. Looks great! I'm not terribly knowledgeable about the (de)serialization aspect on this. |
|
@munrojm , any thoughts before I merge? |
|
@rkingsbury Nope! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When exporting a MongoDB collection to JSON, the resulting format is extended JSON. Trying to load such a JSON file into
JSONStorecurrently fails due to the way extended JSON serializesObjectID, with an error similar toThis PR modifies
JSONStore.read_jsonto use thebson.json_util.loadsmethod if$oidis detected in the file, which allows loading extended JSON files into aJSONStore. If$oidis not there, the currentorjson.loads()is used instead.Unfortunately.
orjson.loadsdoes not support BSON types. This was requested before, although it isn't clear if the maintainer understood the request.Happy to hear opinions if there are better ways to accomplish this, e.g. by leveraging
serialization_helper,MontyDecoder, etc. and/or opening anotherorjsonissue with a more specific request about how to handle these types.