Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tqdm.auto #795

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Use tqdm.auto #795

merged 1 commit into from
Jun 8, 2023

Conversation

utf
Copy link
Member

@utf utf commented Jun 8, 2023

Use tqdm.auto to automatically detect whether you are in a notebook and avoid warnings on tqdm imports.

@utf
Copy link
Member Author

utf commented Jun 8, 2023

Other changes were made by the pre-commmit.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ba7d1fd) 88.12% compared to head (8f843d8) 88.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          44       44           
  Lines        3562     3562           
=======================================
  Hits         3139     3139           
  Misses        423      423           
Impacted Files Coverage Δ
src/maggma/cli/multiprocessing.py 94.73% <100.00%> (ø)
src/maggma/cli/serial.py 79.31% <100.00%> (ø)
src/maggma/utils.py 95.72% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rkingsbury
Copy link
Collaborator

Thanks for this nice enhancement @utf ; I was not aware of tqdm.auto before but now I'm sure I'll use it all the time!

@rkingsbury rkingsbury merged commit 3176c62 into materialsproject:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants