Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GroupBuilder #79

Merged
merged 17 commits into from
Jan 20, 2020
Merged

Updated GroupBuilder #79

merged 17 commits into from
Jan 20, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jan 20, 2020

This PR updates Group Builder to be a bit easier to use and add in documentation

  • Simpler group builder implementation
  • Some basic tests
  • Docs

Some misc fixes:

  • include tqdm progress bar in Builder.run
  • Actually re-run failed keys

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #79 into master will increase coverage by 0.6%.
The diff coverage is 86.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #79     +/-   ##
=========================================
+ Coverage   86.13%   86.73%   +0.6%     
=========================================
  Files          18       20      +2     
  Lines        1298     1365     +67     
=========================================
+ Hits         1118     1184     +66     
- Misses        180      181      +1
Impacted Files Coverage Δ
src/maggma/core/builder.py 92.59% <100%> (+0.92%) ⬆️
src/maggma/stores/__init__.py 100% <100%> (ø) ⬆️
src/maggma/cli/multiprocessing.py 93.93% <100%> (+0.09%) ⬆️
src/maggma/builders/__init__.py 100% <100%> (ø)
src/maggma/builders/map_builder.py 91.2% <77.77%> (ø)
src/maggma/builders/group_builder.py 84.81% <84.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16f9fa...0fa3e1c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2020

This pull request introduces 1 alert when merging 3566059 into c263b94 - view on LGTM.com

new alerts:

  • 1 for Redundant assignment

@shyamd shyamd merged commit eb15853 into master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants