Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default sorting from API #770

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Remove default sorting from API #770

merged 2 commits into from
Jan 30, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 30, 2023

Since API queries are not all aggregation pipelines, default sorting by unique key to ensure deterministic result order can now be removed.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 88.36% // Head: 88.24% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (2af113c) compared to base (0ef72f2).
Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   88.36%   88.24%   -0.12%     
==========================================
  Files          41       41              
  Lines        3163     3165       +2     
==========================================
- Hits         2795     2793       -2     
- Misses        368      372       +4     
Impacted Files Coverage Δ
src/maggma/api/resource/post_resource.py 89.83% <0.00%> (ø)
src/maggma/api/resource/read_resource.py 85.84% <ø> (ø)
src/maggma/api/resource/submission.py 82.11% <ø> (ø)
src/maggma/api/resource/utils.py 80.76% <42.85%> (-15.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 309c370 into main Jan 30, 2023
@munrojm munrojm deleted the bugfix/server_sorting branch February 17, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant