Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation pipelines in resource classes #759

Merged
merged 9 commits into from
Jan 10, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 10, 2023

Convert all calls to query method in Resource classes to aggregation pipelines. This is to ensure determinacy in return results when different skip and limit values are used for the same set of criteria.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 88.42% // Head: 88.45% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (401b510) compared to base (4731ada).
Patch coverage: 88.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   88.42%   88.45%   +0.02%     
==========================================
  Files          41       41              
  Lines        3135     3169      +34     
==========================================
+ Hits         2772     2803      +31     
- Misses        363      366       +3     
Impacted Files Coverage Δ
src/maggma/api/resource/submission.py 82.44% <78.94%> (+0.08%) ⬆️
src/maggma/api/resource/post_resource.py 91.04% <93.33%> (+0.13%) ⬆️
src/maggma/api/resource/read_resource.py 88.49% <94.44%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 4ef25f0 into main Jan 10, 2023
@munrojm munrojm deleted the enhancement/read_resource_aggregation branch February 17, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant