Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default sort on _id for determinacy #732

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 21, 2022

This PR adds a default sort to the MongoDB _id document key to enforce determinacy of document order by default.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 88.37% // Head: 88.37% // No change to project coverage 👍

Coverage data is based on head (9cb6396) compared to base (2c158d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          41       41           
  Lines        3123     3123           
=======================================
  Hits         2760     2760           
  Misses        363      363           
Impacted Files Coverage Δ
src/maggma/stores/mongolike.py 87.97% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit fe2a735 into main Oct 21, 2022
@munrojm munrojm deleted the bugfix/fix_determinacy_mongo branch October 21, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant