Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all fields are properly sanitized #690

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 25, 2022

This PR ensures boolean fields and fields with default factories are sanitized correctly in api_sanitize.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #690 (2ce7d4f) into main (9401791) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   89.43%   89.44%   +0.01%     
==========================================
  Files          42       42              
  Lines        3048     3052       +4     
==========================================
+ Hits         2726     2730       +4     
  Misses        322      322              
Impacted Files Coverage Δ
src/maggma/api/utils.py 95.94% <100.00%> (+0.23%) ⬆️
src/maggma/core/drone.py 92.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53280a...2ce7d4f. Read the comment docs.

@munrojm munrojm merged commit 539f5fc into main Jul 25, 2022
@munrojm munrojm deleted the bugfix/api_model_sanitize branch July 25, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant