Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header processing #679

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix header processing #679

merged 1 commit into from
Jun 7, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jun 7, 2022

This PR fixes a variable name issue that was overwriting the temporary Response object FastAPI uses to extract header data to use in the response. This did not allow the correct header to be processed by a given Resource class.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #679 (0753c8d) into main (b506eb8) will not change coverage.
The diff coverage is 55.55%.

@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          42       42           
  Lines        3048     3048           
=======================================
  Hits         2726     2726           
  Misses        322      322           
Impacted Files Coverage Δ
src/maggma/api/resource/s3_url.py 59.18% <0.00%> (ø)
src/maggma/api/resource/read_resource.py 95.29% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fba26...0753c8d. Read the comment docs.

@munrojm munrojm merged commit 9401791 into main Jun 7, 2022
@munrojm munrojm deleted the bugfix/fix_header_processing branch June 7, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant