Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gridfs URI store #667

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix gridfs URI store #667

merged 2 commits into from
May 24, 2022

Conversation

utf
Copy link
Member

@utf utf commented May 24, 2022

Trying to connect to a GridFSURIStore results in the following error:

Traceback (most recent call last):
  File "/Users/alexmganose/test_connect.py", line 6, in <module>
    store.connect()
  File "/Users/alexmganose/dev/src/jobflow/src/jobflow/core/store.py", line 109, in connect
    additional_store.connect(force_reset=force_reset)
  File "/Users/alexmganose/.conda/envs/atomate2/lib/python3.9/site-packages/maggma/stores/gridfs.py", line 512, in connect
    conn = MongoClient(self.uri, **self.mongoclient_kwargs)
AttributeError: 'GridFSURIStore' object has no attribute 'mongoclient_kwargs'

This PR fixes the error.

If possible, please can you push a new release once this is merged.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #667 (e1fe067) into main (a2b2b60) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          42       42           
  Lines        3047     3048    +1     
=======================================
+ Hits         2725     2726    +1     
  Misses        322      322           
Impacted Files Coverage Δ
src/maggma/stores/gridfs.py 94.41% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3c881...e1fe067. Read the comment docs.

@munrojm munrojm merged commit e84dc1d into materialsproject:main May 24, 2022
@munrojm
Copy link
Member

munrojm commented May 24, 2022

Done, patch releasing now.

@utf
Copy link
Member Author

utf commented May 24, 2022

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants