Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow s3 resource kwargs #665

Merged
merged 2 commits into from
May 23, 2022
Merged

allow s3 resource kwargs #665

merged 2 commits into from
May 23, 2022

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented May 19, 2022

Allow s3 resources Kwargs

Sometimes kwargs like verify=False need to be passed to the call to resource

         resource = session.resource(
            "s3", endpoint_url=self.endpoint_url, **self.s3_resource_kwargs
        )

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #665 (f3cf005) into main (b68e7d7) will increase coverage by 0.00%.
The diff coverage is 92.85%.

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files          41       41           
  Lines        2891     2892    +1     
=======================================
+ Hits         2572     2573    +1     
  Misses        319      319           
Impacted Files Coverage Δ
src/maggma/stores/aws.py 91.70% <92.85%> (+0.04%) ⬆️
src/maggma/core/drone.py 92.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8d7a0...f3cf005. Read the comment docs.

@munrojm munrojm merged commit 1521d10 into materialsproject:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants