Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 store and resource additions #635

Merged
merged 11 commits into from
Apr 19, 2022
Merged

S3 store and resource additions #635

merged 11 commits into from
Apr 19, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 18, 2022

This PR:

  • Allows raw msgpacked and compressed S3 object data to be returned directly through the S3 store
  • Introduces S3URLResource for serving up pre-signed object URLs in S3

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #635 (9cd5db3) into main (6adef9b) will decrease coverage by 0.49%.
The diff coverage is 75.28%.

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   89.46%   88.96%   -0.50%     
==========================================
  Files          40       41       +1     
  Lines        2828     2891      +63     
==========================================
+ Hits         2530     2572      +42     
- Misses        298      319      +21     
Impacted Files Coverage Δ
src/maggma/api/resource/s3_url.py 59.18% <59.18%> (ø)
src/maggma/api/utils.py 95.71% <85.71%> (-1.31%) ⬇️
src/maggma/stores/aws.py 91.66% <95.65%> (+0.25%) ⬆️
src/maggma/api/models.py 90.47% <100.00%> (+1.00%) ⬆️
src/maggma/api/resource/__init__.py 100.00% <100.00%> (ø)
src/maggma/api/resource/read_resource.py 95.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c393da8...9cd5db3. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Apr 18, 2022

This pull request introduces 3 alerts when merging 1f88339 into c393da8 - view on LGTM.com

new alerts:

  • 3 for Unused import

@munrojm munrojm merged commit f8ea9d3 into main Apr 19, 2022
@munrojm munrojm deleted the enhancement/api_s3_changes branch June 30, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant