Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sorting query operator to take multiple fields #500

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 11, 2021

This PR incorporated multi field sorting into the sorting query operator.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #500 (aa019ba) into main (25ad553) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          40       40           
  Lines        2657     2658    +1     
=======================================
+ Hits         2350     2351    +1     
  Misses        307      307           
Impacted Files Coverage Δ
src/maggma/api/query_operator/sorting.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ad553...aa019ba. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2021

This pull request introduces 2 alerts when merging aa019ba into 25ad553 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Non-iterable used in for loop

@munrojm munrojm merged commit dae3a8f into main Oct 11, 2021
@munrojm munrojm deleted the bump_release branch October 11, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant