Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concat store #47

Merged
merged 5 commits into from
Dec 12, 2018
Merged

Concat store #47

merged 5 commits into from
Dec 12, 2018

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Nov 28, 2018

Adds a store that concatenates multiple stores together.

  • Concatenates multiples stores together
  • Purposefully doesn't implement collection or update as these methods are ambiguous when concating stores together.

@coveralls
Copy link

coveralls commented Nov 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 475

  • 65 of 77 (84.42%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 76.631%
Changes Missing Coverage Covered Lines Changed/Added Lines %
maggma/tests/test_advanced_stores.py 28 29 96.55%
maggma/advanced_stores.py 37 48 77.08%
Totals Coverage Status
Change from base Build 470: 0.3%
Covered Lines: 1738
Relevant Lines: 2268
💛 - Coveralls

@shyamd shyamd merged commit f986345 into master Dec 12, 2018
@shyamd shyamd deleted the concat_store branch January 10, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shyamd @coveralls