Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Store.name is a property #449

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Conversation

utf
Copy link
Member

@utf utf commented Jun 2, 2021

The name method should be a property.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #449 (504064a) into main (9e037d7) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   87.77%   87.59%   -0.19%     
==========================================
  Files          34       34              
  Lines        2340     2346       +6     
==========================================
+ Hits         2054     2055       +1     
- Misses        286      291       +5     
Impacted Files Coverage Δ
src/maggma/stores/advanced_stores.py 78.72% <100.00%> (+0.22%) ⬆️
src/maggma/stores/aws.py 88.08% <100.00%> (+0.06%) ⬆️
src/maggma/stores/compound_stores.py 81.31% <100.00%> (+0.20%) ⬆️
src/maggma/stores/gridfs.py 90.97% <100.00%> (+0.06%) ⬆️
src/maggma/stores/mongolike.py 82.12% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bbb44...504064a. Read the comment docs.

@utf utf changed the title Fix GridFS name property Ensure Store.name is a property Jun 2, 2021
@shyamd shyamd merged commit 66e138b into materialsproject:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants