Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to JointStore and MapBuilder #44

Merged
merged 37 commits into from
Oct 26, 2018
Merged

Updates to JointStore and MapBuilder #44

merged 37 commits into from
Oct 26, 2018

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Oct 17, 2018

  • Updated JointStore to be able to merge across the lookup to the root level.
    This makes the aggregation look seamless to the person using the JointStore.
  • Modified MapBuilder to get_keys and then chunk those when requesting data.
    This allows the MapBuilder to run in incremental mode by default.

Todo: Still thinking about how the index functions should be incorporated into MongoStore such that MapBuilder is not calling pymongo functions.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 449

  • 72 of 82 (87.8%) changed or added relevant lines in 7 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.07%) to 76.457%

Changes Missing Coverage Covered Lines Changed/Added Lines %
maggma/examples/builders.py 20 21 95.24%
maggma/examples/tests/test_copybuilder.py 3 4 75.0%
maggma/cli/mrun.py 0 2 0.0%
maggma/tests/test_advanced_stores.py 24 26 92.31%
maggma/advanced_stores.py 21 25 84.0%
Files with Coverage Reduction New Missed Lines %
maggma/advanced_stores.py 1 72.73%
maggma/tests/test_advanced_stores.py 1 95.85%
maggma/cli/mrun.py 1 0.0%
maggma/utils.py 16 52.34%
Totals Coverage Status
Change from base Build 424: -1.07%
Covered Lines: 1614
Relevant Lines: 2111

💛 - Coveralls

@shyamd
Copy link
Contributor Author

shyamd commented Oct 26, 2018

Ok, This finally works. I think the test is a little mangled, but it was the only way I could get MongoDB 3.6 on the old trusty image that TravisCI seems to use.

@shyamd shyamd merged commit 94ca173 into master Oct 26, 2018
@shyamd shyamd deleted the joinstore_updates branch November 1, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants