Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS Bucket Detection #429

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Update AWS Bucket Detection #429

merged 2 commits into from
Apr 16, 2021

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Apr 16, 2021

changed how we detect buckets

changed how we detect buckets
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #429 (7bf6ae3) into main (672c6ae) will decrease coverage by 0.25%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   86.96%   86.71%   -0.26%     
==========================================
  Files          28       28              
  Lines        2225     2228       +3     
==========================================
- Hits         1935     1932       -3     
- Misses        290      296       +6     
Impacted Files Coverage Δ
src/maggma/stores/aws.py 84.91% <75.00%> (-0.32%) ⬇️
src/maggma/stores/mongolike.py 82.12% <0.00%> (-1.91%) ⬇️
src/maggma/core/drone.py 92.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672c6ae...7bf6ae3. Read the comment docs.

@shyamd shyamd changed the title Update aws.py Update AWS Bucket Detection Apr 16, 2021
@shyamd shyamd merged commit a5c3361 into materialsproject:main Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants