Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the GridFSStore does not allow to access data from gridfs collections that were not generated with maggma, since they will not contain the
metadata
value. This PR aims to allow the retrieval of data from a generic gridfs collection.In its current form however the method returns the bytes extracted from the gridfs and not a dict, as required by the API. In general this could happen if this json.loads fails:
https://github.com/materialsproject/maggma/blob/master/src/maggma/stores/gridfs.py#L209
Would you agree to also replace this with:
?