Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Distinct in MongoStore #332

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Fix Distinct in MongoStore #332

merged 2 commits into from
Nov 17, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Nov 17, 2020

Fix the distinct operation from failing in the MongoStore when too much data is being pulled. This broke because pymongo made an explicit DocumentTooLarge error that was not being caught.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #332 (0d54956) into master (6661534) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   87.41%   87.51%   +0.09%     
==========================================
  Files          28       28              
  Lines        2170     2170              
==========================================
+ Hits         1897     1899       +2     
+ Misses        273      271       -2     
Impacted Files Coverage Δ
src/maggma/stores/mongolike.py 82.42% <100.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d7030...0d54956. Read the comment docs.

@shyamd shyamd merged commit 1848830 into master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant