Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct passing of AWS login to S3Store #326

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Direct passing of AWS login to S3Store #326

merged 4 commits into from
Nov 13, 2020

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Nov 12, 2020

Now allows AWS information to be giving as the s3_profile (should consider renaming the parameter to s3_login).

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #326 (a6fdb57) into master (94877f1) will decrease coverage by 1.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   88.02%   86.91%   -1.12%     
==========================================
  Files          28       28              
  Lines        2130     2170      +40     
==========================================
+ Hits         1875     1886      +11     
- Misses        255      284      +29     
Impacted Files Coverage Δ
src/maggma/stores/aws.py 85.05% <100.00%> (+0.44%) ⬆️
src/maggma/stores/mongolike.py 76.98% <0.00%> (-10.27%) ⬇️
src/maggma/api/query_operator.py 83.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94877f1...a6fdb57. Read the comment docs.

@shyamd
Copy link
Contributor

shyamd commented Nov 13, 2020

Looks good!

@shyamd shyamd merged commit 6661534 into materialsproject:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants