Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap SSHTunnelForward and make it MSONable #320

Merged
merged 9 commits into from
Nov 6, 2020
Merged

Wrap SSHTunnelForward and make it MSONable #320

merged 9 commits into from
Nov 6, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Nov 5, 2020

This PR makes the ssh tunnel feature MSONable so that we can serialize and deserialize this information.

@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2020

This pull request introduces 2 alerts when merging a1d97b5 into 0243662 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Binding a socket to all network interfaces

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #320 into master will decrease coverage by 1.10%.
The diff coverage is 36.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   88.49%   87.39%   -1.11%     
==========================================
  Files          28       28              
  Lines        2121     2165      +44     
==========================================
+ Hits         1877     1892      +15     
- Misses        244      273      +29     
Impacted Files Coverage Δ
src/maggma/api/APIManager.py 72.09% <ø> (ø)
src/maggma/api/resource.py 98.14% <ø> (ø)
src/maggma/utils.py 93.96% <ø> (ø)
src/maggma/stores/mongolike.py 81.58% <34.69%> (-12.04%) ⬇️
src/maggma/api/query_operator.py 83.50% <100.00%> (ø)
src/maggma/stores/aws.py 84.61% <0.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0199045...07b1e2c. Read the comment docs.

@shyamd shyamd merged commit 22c8603 into master Nov 6, 2020
@shyamd shyamd deleted the msonable_ssh branch November 6, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant