-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fix to make sure searchable_fields are updated #303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 88.49% 88.02% -0.47%
==========================================
Files 28 28
Lines 2121 2130 +9
==========================================
- Hits 1877 1875 -2
- Misses 244 255 +11
Continue to review full report at Codecov.
|
@munrojm this should fix the speed issues and make the CopyBuilder usable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested change.
Various fixes
newer_in
function inS3Store
should only look in the the index store of the targetsearchable_fields
must be included in thesearch_keys
in the multiprocessing verion of the update function