Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to make sure searchable_fields are updated #303

Merged
merged 31 commits into from
Nov 2, 2020
Merged

Small fix to make sure searchable_fields are updated #303

merged 31 commits into from
Nov 2, 2020

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Oct 8, 2020

Various fixes

  • newer_in function in S3Store should only look in the the index store of the target
  • searchable_fields must be included in the search_keys in the multiprocessing verion of the update function
  • typos in docs

@jmmshn jmmshn marked this pull request as draft October 8, 2020 19:52
@jmmshn jmmshn marked this pull request as ready for review October 23, 2020 17:14
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #303 into master will decrease coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   88.49%   88.02%   -0.47%     
==========================================
  Files          28       28              
  Lines        2121     2130       +9     
==========================================
- Hits         1877     1875       -2     
- Misses        244      255      +11     
Impacted Files Coverage Δ
src/maggma/stores/aws.py 84.61% <100.00%> (+2.11%) ⬆️
src/maggma/stores/mongolike.py 87.25% <0.00%> (-6.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edebb7d...94877f1. Read the comment docs.

@jmmshn
Copy link
Contributor Author

jmmshn commented Oct 31, 2020

@munrojm this should fix the speed issues and make the CopyBuilder usable.

Copy link
Contributor

@shyamd shyamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change.

src/maggma/stores/aws.py Outdated Show resolved Hide resolved
@shyamd shyamd merged commit 7b180ec into materialsproject:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants