Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added context manager for stores #258

Merged
merged 9 commits into from
Aug 26, 2020
Merged

added context manager for stores #258

merged 9 commits into from
Aug 26, 2020

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Aug 26, 2020

  • added context manager for stores
  • set index key with kwarg in S3Store.init
  • changed test case so we actually test S3Store.update(dict) and S3Store.update(List[dict])

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #258 into master will decrease coverage by 0.04%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   87.64%   87.59%   -0.05%     
==========================================
  Files          27       27              
  Lines        2007     2016       +9     
==========================================
+ Hits         1759     1766       +7     
- Misses        248      250       +2     
Impacted Files Coverage Δ
src/maggma/core/store.py 85.56% <40.00%> (-2.48%) ⬇️
src/maggma/stores/aws.py 81.52% <100.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4133e...4084988. Read the comment docs.

@shyamd shyamd merged commit 284cad8 into materialsproject:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants