-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixes to S3Store #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 88.33% 87.64% -0.70%
==========================================
Files 27 27
Lines 2006 2007 +1
==========================================
- Hits 1772 1759 -13
- Misses 234 248 +14
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 9c78c5a into 3b4832c - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unpacking issue
Reconstructing data from msgpack is not compatible with how monty wants to reconstruct objects.
msgpack wants to go as deep as possible first, but monty wants to stop when it finds a from_dict
So now we use
MontyDecoder().process_decoded
and issue should be resolved.Doing this also allows us to bypass string conversion (json.dumps) which gives us up to 5x speedup when processing CHGCARs and 1.5x on bandstructures.
Fixed mismatched between documentation and functionality of
update
functionNow allows for a single document to be updated