Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes to S3Store #253

Merged
merged 12 commits into from
Aug 21, 2020
Merged

Minor bug fixes to S3Store #253

merged 12 commits into from
Aug 21, 2020

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Aug 21, 2020

Fix for unpacking issue

Reconstructing data from msgpack is not compatible with how monty wants to reconstruct objects.
msgpack wants to go as deep as possible first, but monty wants to stop when it finds a from_dict

So now we use MontyDecoder().process_decoded and issue should be resolved.

Doing this also allows us to bypass string conversion (json.dumps) which gives us up to 5x speedup when processing CHGCARs and 1.5x on bandstructures.

Fixed mismatched between documentation and functionality of update function

Now allows for a single document to be updated

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #253 into master will decrease coverage by 0.69%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   88.33%   87.64%   -0.70%     
==========================================
  Files          27       27              
  Lines        2006     2007       +1     
==========================================
- Hits         1772     1759      -13     
- Misses        234      248      +14     
Impacted Files Coverage Δ
src/maggma/stores/aws.py 80.39% <66.66%> (-0.53%) ⬇️
src/maggma/stores/mongolike.py 87.25% <0.00%> (-6.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4832c...0a4133e. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 21, 2020

This pull request introduces 1 alert when merging 9c78c5a into 3b4832c - view on LGTM.com

new alerts:

  • 1 for Unused import

@shyamd shyamd merged commit 1838f6b into materialsproject:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants