Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon S3 store update #110

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Amazon S3 store update #110

merged 6 commits into from
Mar 23, 2020

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Mar 4, 2020

AWS profile option added. Also, data will be pulled from S3 index store on query before S3 bucket if possible.

@shyamd
Copy link
Contributor

shyamd commented Mar 11, 2020

I pushed some clean up commits. Can you add a test for the new behavior?

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #110 into master will decrease coverage by 0.74%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   81.57%   80.82%   -0.75%     
==========================================
  Files          21       21              
  Lines        1563     1575      +12     
==========================================
- Hits         1275     1273       -2     
- Misses        288      302      +14     
Impacted Files Coverage Δ
src/maggma/stores/aws.py 76.27% <85.71%> (-0.15%) ⬇️
src/maggma/stores/mongolike.py 88.48% <0.00%> (-5.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3078a...59c42ab. Read the comment docs.

@munrojm
Copy link
Member Author

munrojm commented Mar 12, 2020

I pushed some clean up commits. Can you add a test for the new behavior?

Thanks! Sure, no problem.

@shyamd shyamd merged commit d05050b into materialsproject:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants