Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit mode in zopen to address monty FutureWarning #1021

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

rkingsbury
Copy link
Collaborator

Explicitly sets mode='r' in zopen to avoid the following:

/home/ryan/miniforge3/envs/feynman/lib/python3.12/site-packages/maggma/stores/mongolike.py:712: FutureWarning: We strongly discourage using a default `mode`, it would beset to `r` now but would not be allowed after 2025-06-01
  with zopen(path) as f:

Addresses a FutureWarning introduced in latest monty
@rkingsbury rkingsbury added release:patch pkg Package and repository health housekeeping labels Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (4ed05b8) to head (2d6fbb2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files          46       46           
  Lines        3997     3997           
=======================================
  Hits         3554     3554           
  Misses        443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit 1e382c0 into materialsproject:main Dec 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping pkg Package and repository health release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant