Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to URI store #1014

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Dec 2, 2024

Minor fix to URI store

Added safe_update to MongoURIStore.__init__.

Please see discussion on #1013.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (668c2e4) to head (e69ea16).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files          46       46           
  Lines        3989     3990    +1     
=======================================
+ Hits         3544     3545    +1     
  Misses        445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn changed the title patch Minor fix to URI store Dec 2, 2024
@jmmshn jmmshn marked this pull request as ready for review December 2, 2024 03:59
@rkingsbury rkingsbury merged commit dc204f8 into materialsproject:main Dec 3, 2024
10 checks passed
@rkingsbury
Copy link
Collaborator

Thanks @jmmshn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants