Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupBuilder: fix query kwarg and add tests #1002

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

rkingsbury
Copy link
Collaborator

Summary

GroupBuilder has a query kwarg that is supposed to provide filtering of items from the source store, but it does not function correctly and has not been tested.

This PR implements the intended functionality of query and adds tests for it.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (216f1a6) to head (c1ef139).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/maggma/builders/group_builder.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files          46       46           
  Lines        3989     3989           
=======================================
  Hits         3544     3544           
  Misses        445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit 2ab7815 into materialsproject:main Oct 8, 2024
9 of 10 checks passed
@rkingsbury rkingsbury deleted the groupquery branch October 8, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant