-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] Edge case for Magmoms #460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a strange interaction between charge-decorated structures and magmoms. Charge-decorated structures can `site.species.spin == None` which would lead to a result of `[None, ....]` for the `_get_magmoms` function and then lead to failure when writing the INCAR
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 65.30% 65.15% -0.16%
==========================================
Files 74 74
Lines 7186 7186
Branches 927 927
==========================================
- Hits 4693 4682 -11
- Misses 2208 2220 +12
+ Partials 285 284 -1
|
Thanks @jmmshn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a strange interaction between charge-decorated structures and magmoms.
Charge-decorated structures can
site.species.spin == None
which would lead to a result of[None, ....]
for the_get_magmoms
function and then lead to failure when writing the INCAR