Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playwright folder #1562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bart-krakowski
Copy link
Contributor

@bart-krakowski bart-krakowski commented Jun 13, 2022

This PR introduces an icon for the Playwright folder.

Closes: #1550

playwright

@JonatanLindstrom
Copy link
Contributor

Is pw tightly coupled to playwright? In my opinion it could mean a lot of different things and my first thought would be it was a folder of passwords or auth related stuff. Maybe it's a risk of getting "false positives" to have it linked to an abbreviation?

@PKief
Copy link
Member

PKief commented Nov 5, 2022

I'd also remove the "pw" folder name. It's too generic. In addition the red color of the motive does not fit to the general styling of the folder icons in this extension. I'd prefer it if folder icons only have two colors: one for the folder icon itself and one single brighter color for the specific motive in the front.

@sghsri
Copy link

sghsri commented Mar 23, 2023

any update on this PR? It would be awesome if it got merged in, and I see that the "pw" folder name was removed as per the comments @PKief

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Playwright icon folder
5 participants