Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More React+Redux Ecosystem Icons #255

Closed
oscarCrespo opened this issue May 21, 2018 · 11 comments
Closed

More React+Redux Ecosystem Icons #255

oscarCrespo opened this issue May 21, 2018 · 11 comments

Comments

@oscarCrespo
Copy link

Would be great to have more React-Redux ecosystem icons, like:

  • Redux Icon
  • Redux Sagas Icon
  • Redux Icons with Color Variations (see below)
  • React Router

We organize our redux code by Modules, it look like this:
image

So we would love to be able to assign different redux icons, on the reducer.js and actions.js files.

Thanks a lot for this great icon library,

@PKief
Copy link
Member

PKief commented May 21, 2018

Thanks for the nice feedback. In the near future I'll definitely invest some time in more Redux Icons 😎

@PKief
Copy link
Member

PKief commented May 25, 2018

I finally created new Redux file icons:

redux file icons

What do you think about these icons?

I was wondering if there's a common file name for the react router files? Should we just use router.js or what do you think?

Besides, the saga's icon doesn't really fit to my icon theme. I would like to leave it for now by the "standard" redux icons as shown in the image above.

However, it would be of great advantage, if the VS Code API would provide glob file patterns for the icon associations. Thus we are currently limited to specific file names and extensions.

@oscarCrespo
Copy link
Author

Cool, I they look great. About react-router, I personally call it routes.js, I don't think there's a convention for the file, but I think routes or router are the standard.

I agree glob patterns would improve the flexibility a lot, I hope they add it soon.

Thanks a lot for the quick response.

@PKief
Copy link
Member

PKief commented May 28, 2018

The React router icon could look like this:

react-router-icon

I prefer the green color because it matches the "routes" folder icon very well.

Another option would be the same icon that I use for the angular router:

react-router-icon

Which icon would you prefer?

Btw: I also tried the official logo but I think it is not very suitable as file icon.

@PKief
Copy link
Member

PKief commented May 28, 2018

I had another thought: We could use the first version (with the green react logo) and if the people prefer the same logo as for angular they can customize it in their user settings like this:

"material-icon-theme.files.associations": {
    "Router.js": "angular-routing"
}

I don't mind 😄

@oscarCrespo
Copy link
Author

Yeah that sounds great, I like a lot the angular router Icon I think it works perfect. You're right the official logo doesn't play great with dark background and small size.

PKief added a commit that referenced this issue May 29, 2018
@PKief
Copy link
Member

PKief commented May 29, 2018

I appreciate your feedback. You will receive the update within the next few days 😃

@nonewcode
Copy link

Can we get a saga icon done as well please? my OCD kicks in when i create them and there's no icon haha

@PKief
Copy link
Member

PKief commented Jan 12, 2019

@JoshuaKelly
As I said in my comment above:

Besides, the saga's icon doesn't really fit to my icon theme. I would like to leave it for now by the "standard" redux icons as shown in the image above.

I'm still of the opinion that the logo of redux-saga does not fit to the theme. I already tried to create one and I was not satisfied at all.

@Donkijote
Copy link

@PKief The react route green color icon was delete?

@amitjoshi956
Copy link

@PKief Requesting some icons for Redux middlewares as well 🙏🏻😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants