-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More React+Redux Ecosystem Icons #255
Comments
Thanks for the nice feedback. In the near future I'll definitely invest some time in more Redux Icons 😎 |
I finally created new Redux file icons: What do you think about these icons? I was wondering if there's a common file name for the react router files? Should we just use Besides, the saga's icon doesn't really fit to my icon theme. I would like to leave it for now by the "standard" redux icons as shown in the image above. However, it would be of great advantage, if the VS Code API would provide glob file patterns for the icon associations. Thus we are currently limited to specific file names and extensions. |
Cool, I they look great. About react-router, I personally call it I agree glob patterns would improve the flexibility a lot, I hope they add it soon. Thanks a lot for the quick response. |
The React router icon could look like this: I prefer the green color because it matches the "routes" folder icon very well. Another option would be the same icon that I use for the angular router: Which icon would you prefer? Btw: I also tried the official logo but I think it is not very suitable as file icon. |
I had another thought: We could use the first version (with the green react logo) and if the people prefer the same logo as for angular they can customize it in their user settings like this: "material-icon-theme.files.associations": {
"Router.js": "angular-routing"
} I don't mind 😄 |
Yeah that sounds great, I like a lot the angular router Icon I think it works perfect. You're right the official logo doesn't play great with dark background and small size. |
I appreciate your feedback. You will receive the update within the next few days 😃 |
Can we get a saga icon done as well please? my OCD kicks in when i create them and there's no icon haha |
@JoshuaKelly
I'm still of the opinion that the logo of redux-saga does not fit to the theme. I already tried to create one and I was not satisfied at all. |
@PKief The react route green color icon was delete? |
@PKief Requesting some icons for Redux middlewares as well 🙏🏻😁 |
Would be great to have more React-Redux ecosystem icons, like:
We organize our redux code by Modules, it look like this:
So we would love to be able to assign different redux icons, on the reducer.js and actions.js files.
Thanks a lot for this great icon library,
The text was updated successfully, but these errors were encountered: