Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formDisabledCallback and <fieldset> disabled attribute #5565

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

datvm
Copy link
Contributor

@datvm datvm commented Apr 3, 2024

Fixes #5049 where the control disabled property itself is changed which would cause issues for fieldset.

This commit need to be merged along with #5563. I am sorry I am not familiar with the process of one PR depends on the other. In that commit, the render/UI/behavior make use of :disabled instead of the disabled property only, therefore the behavior should matches with native elements:

Recording.2024-04-03.192904.mp4

@asyncLiz
Copy link
Collaborator

asyncLiz commented Apr 3, 2024

Let's wait for #5563 to land, then you can sync to head for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use formDisabledCallback to support <fieldset> disabled attribute
2 participants