Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): center items in blockquotes #5074

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

vdegenne
Copy link
Contributor

Elements are not properly centered in blockquotes I noticed:

image

@vdegenne
Copy link
Contributor Author

vdegenne commented Oct 11, 2023

I bumped the first element with a 4px top margin which makes the content look centered when there is alone one line, and it doesn't create a visual discomfort in the case of paragraphs.

@e111077 is it good?

@e111077 e111077 added preview-catalog Will run the github action to deploy a preview of the catalog and removed preview-catalog Will run the github action to deploy a preview of the catalog labels Oct 11, 2023
@e111077
Copy link
Contributor

e111077 commented Oct 11, 2023

heya thanks for the tag. Unfortunately the automation to launch the catalog doesn't work on forks. I wonder if i could fix that without exposing our CI and Firebase resources to different projects not contributing to this project.

@copybara-service copybara-service bot merged commit c0e39d9 into material-components:main Oct 13, 2023
5 checks passed
@vdegenne
Copy link
Contributor Author

@e111077 You found a way I see.

@vdegenne vdegenne deleted the patch-5 branch October 13, 2023 18:56
@e111077
Copy link
Contributor

e111077 commented Oct 13, 2023

I opened it in codespaces and ran it there. Much easier than cloning and getting a local version going

@vdegenne
Copy link
Contributor Author

Haha!
Should I do something specific next time I find another change I can make?

@e111077
Copy link
Contributor

e111077 commented Oct 17, 2023

No it's something we need to figure out here:

https://github.com/material-components/material-web/blob/main/.github/workflows/firebase-hosting-pull-request.yml#L10C57-L10C123

We check if it's our repo because we don't want someone to fork and be able to deploy to our firebase instance / use our resources for their personal needs.

Maybe this is not necessary since I don't think forks have our secrets. Or maybe we should change that check to see if it has a pull request target of our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-catalog Will run the github action to deploy a preview of the catalog Ready for Google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants