Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: npmignore node modules from catalog #4448

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

e111077
Copy link
Contributor

@e111077 e111077 commented Jun 13, 2023

fixes #4446

Tested locally with npm publish --dry-run

Recommend a bugfix deploy after.

@e111077 e111077 marked this pull request as ready for review June 13, 2023 22:43
@e111077 e111077 requested a review from asyncLiz June 13, 2023 22:43
@asyncLiz
Copy link
Collaborator

Looks good to import

@copybara-service copybara-service bot merged commit 191b3d2 into main Jun 14, 2023
@copybara-service copybara-service bot deleted the do-not-publish-catalog-node-modules branch June 14, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not publish catalog\node_modules\typescript directory to NPM
2 participants