Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: setup the npm workspace for the catalog #4311

Merged
merged 3 commits into from
May 23, 2023
Merged

build: setup the npm workspace for the catalog #4311

merged 3 commits into from
May 23, 2023

Conversation

e111077
Copy link
Contributor

@e111077 e111077 commented May 18, 2023

We have to do this externally because we don't sync the package-lock internally and CI runs npm ci which breaks due to a mismatch between package.json and package-lock.json

@e111077 e111077 marked this pull request as ready for review May 18, 2023 02:27
@e111077 e111077 requested review from asyncLiz and sorvell May 18, 2023 02:28
asyncLiz
asyncLiz approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e111077
Copy link
Contributor Author

e111077 commented May 23, 2023

OMG COPYBARA COPY!

@copybara-service copybara-service bot merged commit 15e60e3 into main May 23, 2023
@copybara-service copybara-service bot deleted the catalog-shell branch May 23, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asyncLiz asyncLiz asyncLiz approved these changes

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes Ready for Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e111077 @asyncLiz