Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I cannot found where the md-typescale.js is. #5524

Closed
gkj17 opened this issue Mar 13, 2024 · 3 comments · Fixed by #5535
Closed

I cannot found where the md-typescale.js is. #5524

gkj17 opened this issue Mar 13, 2024 · 3 comments · Fixed by #5535
Assignees
@asyncLiz

Comments

@gkj17
Copy link

gkj17 commented Mar 13, 2024

Description

import {styles as typescaleStyles} from '../../typography/md-typescale.js';

Browser/OS Environment

No response
@asyncLiz asyncLiz self-assigned this Mar 13, 2024
@asyncLiz
Copy link
Collaborator

Looks like it isn't getting published. I'll check on that

@gkj17
Copy link
Author

gkj17 commented Mar 14, 2024

Thanks, looking forward to your reply!

copybara-service bot pushed a commit that referenced this issue Mar 20, 2024
@asyncLiz @copybara-github
fix(typography): rename md-typescale.js to md-typescale-styles.js
37ab892 
Fixes #5524

This fixes the new md-typescale file not being published. Our build assumes CSS-to-JS files end in "-styles".

This isn't a breaking change since the typescale classes haven't been published yet.

PiperOrigin-RevId: 617573563
@copybara-service copybara-service bot mentioned this issue Mar 20, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Mar 20, 2024
@asyncLiz @copybara-github
fix(typography): rename md-typescale.js to md-typescale-styles.js
7f70f75 
Fixes #5524

This fixes the new md-typescale file not being published. Our build assumes CSS-to-JS files end in "-styles".

This isn't a breaking change since the typescale classes haven't been published yet.

PiperOrigin-RevId: 617573563
copybara-service bot pushed a commit that referenced this issue Mar 20, 2024
@asyncLiz @copybara-github
fix(typography): rename md-typescale.js to md-typescale-styles.js
088c32f 
Fixes #5524

This fixes the new md-typescale file not being published. Our build assumes CSS-to-JS files end in "-styles".

This isn't a breaking change since the typescale classes haven't been published yet.

PiperOrigin-RevId: 617573563
@asyncLiz
Copy link
Collaborator

This will be good to go in 1.4.0, which should be published tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asyncLiz asyncLiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(typography): rename md-typescale.js to md-typescale-styles.js material-components/material-web
2 participants
@gkj17 @asyncLiz