-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Select aria-expanded is never false #5360
Closed
NicholasNewlandsDR opened this issue
Jan 2, 2024
· 1 comment
· Fixed by #5376 or #5295 · May be fixed by X-oss-byte/pigweed#61, X-oss-byte/pigweed#70 or X-oss-byte/pigweed#73
Closed
[a11y] Select aria-expanded is never false #5360
NicholasNewlandsDR opened this issue
Jan 2, 2024
· 1 comment
· Fixed by #5376 or #5295 · May be fixed by X-oss-byte/pigweed#61, X-oss-byte/pigweed#70 or X-oss-byte/pigweed#73
Comments
asyncLiz
changed the title
Select aria-expanded is never false
[a11y] Select aria-expanded is never false
Jan 2, 2024
Word from our A11y people. omitting it is correct, but adding false is also correct in many cases Currently refactoring select to add |
copybara-service bot
pushed a commit
that referenced
this issue
Jan 11, 2024
fixes #5360 PiperOrigin-RevId: 596495202
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is affected?
Accessibility
Description
This line should be 'true': 'false' instead of 'nothing'.
Currently this fails the basic Chai A11y aXe to.be.accessible() check.
Reproduction
Add the element and try and test the accessibility using the method in the provided link.
Workaround
When testing the accessibility of a form, you will need to test each element skipping over the select instead of simply running the test on a wrapping element.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
Failing in 1.1.1
Browser/OS/Node environment
Using the recommended web-test-runner.
The text was updated successfully, but these errors were encountered: