Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] dialog opened by default not showing #4728

Closed
maicol07 opened this issue Aug 17, 2023 · 1 comment · Fixed by #4759 or #4762
Closed

[Dialog] dialog opened by default not showing #4728

maicol07 opened this issue Aug 17, 2023 · 1 comment · Fixed by #4759 or #4762
Assignees
@asyncLiz

Comments

@maicol07
Copy link

maicol07 commented Aug 17, 2023 •
edited
Loading

Hi,
it seems that setting the open attribute before page loading/creation (before the element is added to the DOM) causes to show only the scrim and not the dialog. Subsequent openings work fine.
Live demo
Current behaviour
image
Expected behaviour
image
@maicol07 maicol07 changed the title [Dialog] dialog opened by default doesn't open [Dialog] dialog opened by default isn't open Aug 17, 2023
@maicol07 maicol07 changed the title [Dialog] dialog opened by default isn't open [Dialog] dialog opened by default not showing Aug 17, 2023
@asyncLiz asyncLiz self-assigned this Aug 17, 2023
@VandeurenGlenn
Copy link
Contributor

VandeurenGlenn commented Aug 20, 2023 •
edited
Loading

Just encountered this also

Updating open in firstUpdate should fix it

edit: it didn't

copybara-service bot pushed a commit that referenced this issue Aug 21, 2023
@asyncLiz @copybara-github
fix(dialog): not showing if opened before connected
9720fb0 
Fixes #4728

PiperOrigin-RevId: 558822066
@copybara-service copybara-service bot mentioned this issue Aug 21, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Aug 22, 2023
@asyncLiz @copybara-github
fix(dialog): not showing if opened before connected
482bff4 
Fixes #4728

PiperOrigin-RevId: 558822066
@release-please release-please bot mentioned this issue Aug 22, 2023
Merged
@copybara-service copybara-service bot mentioned this issue Aug 22, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Aug 22, 2023
@asyncLiz @copybara-github
fix(dialog): content not displaying on Safari
72b5458 
Fixes #4728

PiperOrigin-RevId: 558856195
copybara-service bot pushed a commit that referenced this issue Aug 22, 2023
@asyncLiz @copybara-github
fix(dialog): content not displaying on Safari
796f6e2 
Fixes #4728

PiperOrigin-RevId: 558856195
copybara-service bot pushed a commit that referenced this issue Aug 22, 2023
@asyncLiz @copybara-github
fix(dialog): content not displaying on Safari
9b7647b 
Fixes #4728

PiperOrigin-RevId: 559224134
@release-please release-please bot mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asyncLiz asyncLiz

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VandeurenGlenn @maicol07 @asyncLiz