Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form validation not working #4435

Closed
maicol07 opened this issue Jun 12, 2023 · 1 comment · Fixed by #4691
Closed

Form validation not working #4435

maicol07 opened this issue Jun 12, 2023 · 1 comment · Fixed by #4691
Assignees
@asyncLiz

Comments

@maicol07
Copy link

maicol07 commented Jun 12, 2023 •
edited
Loading

Form reportValidity isn't working when submitting or using dedicated methods (checkValidity and reportValidity). Works on individual fields

Demo: Lit playground
@asyncLiz
Copy link
Collaborator

I don't believe native form validity has been hooked up yet. Still working on that for text field, then others

@asyncLiz asyncLiz self-assigned this Jun 12, 2023
@copybara-service copybara-service bot mentioned this issue Aug 17, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Aug 17, 2023
@asyncLiz @copybara-github
fix(textfield): add form validity support
a2bf103 
Also fixes form.reportValidity() not working for checkbox.

Fixes #4435

PiperOrigin-RevId: 557616808
copybara-service bot pushed a commit that referenced this issue Aug 17, 2023
@asyncLiz @copybara-github
fix(textfield): add form validity support
1f2a9a0 
Also fixes form.reportValidity() not working for checkbox.

Fixes #4435

PiperOrigin-RevId: 557616808
@release-please release-please bot mentioned this issue Aug 16, 2023
Merged
@release-please release-please bot mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asyncLiz asyncLiz

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maicol07 @asyncLiz