Bug on @theme mixin in _text-button.scss, _tonal-button.scss, and _outlined-button.scss #4095
Assignees
Comments
hermantolim
changed the title
hermantolim
changed the title
|
Oof I don't think that is intentional. I'll send out a fix |
copybara-service bot
pushed a commit
that referenced
this issue
Mar 29, 2023
Fixes #4095 PiperOrigin-RevId: 520367869
copybara-service bot
pushed a commit
that referenced
this issue
Mar 29, 2023
Fixes #4095 PiperOrigin-RevId: 520367869
copybara-service bot
pushed a commit
that referenced
this issue
Apr 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.6](v1.0.0-pre.5...v1.0.0-pre.6) (2023-04-06) ### ⚠ BREAKING CHANGES * **elevation:** remove elevation surfaces * **iconbutton:** rename selected aria label property, add documentation * **elevation:** remove surface for tonal surface update * **iconbutton:** combine button, link, and toggle variants into single components * **button:** merge standard and link buttons ### Features * **circular-progress:** adds circular-progress element ([3adab6a](3adab6a)) * **focus:** export the keydown handler ([d7fdfda](d7fdfda)) * **focus:** implement focus ring animation ([85232d5](85232d5)) * **iconbutton:** combine button, link, and toggle variants into single components ([0aa39e8](0aa39e8)) * **iconbutton:** rename selected aria label property, add documentation ([5d3af37](5d3af37)) * **list,menu:** implement forced colors ([712aab3](712aab3)) * **tokens:** generate v0.170 ([2b9daea](2b9daea)) * **tokens:** generate v0.172 ([189ef06](189ef06)) ### Bug Fixes * **button:** incorrect theme custom properties ([2c1c80d](2c1c80d)), closes [#4095](#4095) * **button:** merge standard and link buttons ([acfdbb4](acfdbb4)) * **button:** tonal surface update ([50157e6](50157e6)) * **checkbox:** tonal surface update ([7279356](7279356)) * **chips:** tonal surface update ([60ef2ab](60ef2ab)) * complete tonal surface update ([7368e2a](7368e2a)) * **dialog:** tonal surface update ([c64f416](c64f416)) * **elevation:** remove elevation surfaces ([d801a5f](d801a5f)) * **fab:** tonal surface update ([92a9071](92a9071)) * **iconbutton:** tonal surface update ([52b45f1](52b45f1)) * **list:** fix strong focus first keyboard nav ([6398186](6398186)) * **menu:** close menu on focusout and make it configurable ([3445b63](3445b63)) * **menu:** properly implement selected state ([bfa1bec](bfa1bec)) * **menu:** tonal surface update ([7ccc21e](7ccc21e)) * **navigationbar:** tonal surface update ([ebe666e](ebe666e)) * **navigationbar:** tonal surface update ([a5fe8f3](a5fe8f3)) * **navigationdrawer:** tonal surface update ([4f9df51](4f9df51)) * **radio:** tonal surface update ([b5065a6](b5065a6)) * **ripple:** tonal surface update ([f08a9db](f08a9db)) * **slider:** tonal surface update ([9a020b9](9a020b9)) * **switch:** tonal surface update ([6ccc759](6ccc759)) * **textfield:** tonal surface update ([f15d8ca](f15d8ca)) ### Miscellaneous Chores * **elevation:** remove surface for tonal surface update ([d12ed3e](d12ed3e)) * update next version ([a878783](a878783)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). COPYBARA_INTEGRATE_REVIEW=#4078 from material-components:release-please--branches--master--components--web 9dce2e3 PiperOrigin-RevId: 523131857
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
extra
--md-elevated-button-on token loop, should not be there, this cause wrong token when generating using theme mixinmaterial-web/button/lib/_text-button.scss
Line 20 in bfa1bec
also in
material-web/button/lib/_tonal-button.scss
Line 22 in bfa1bec
and
material-web/button/lib/_outlined-button.scss
Line 24 in bfa1bec
or is it intentional?
The text was updated successfully, but these errors were encountered: