Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-dialog height is wrong on Chrome on Android (address bar issue) #4080

Closed
rbjarnason opened this issue Mar 22, 2023 · 2 comments · Fixed by #4190
Closed

md-dialog height is wrong on Chrome on Android (address bar issue) #4080

rbjarnason opened this issue Mar 22, 2023 · 2 comments · Fixed by #4190

Comments

@rbjarnason
Copy link

md-dialog height is wrong on Chrome on Android where the footer is not visible and if there is scrollable content the user is stuck without getting to for example an exit button in the footer.

image

@sorvell
Copy link
Collaborator

sorvell commented Mar 23, 2023

Good catch! See discord thread.

I noted a few problems when investigating.

  • sizes in the dialog are using vh instead of dvh: this should just be changed.
  • in fullscreen mode, the settable container tokens are not honored: probably should just remove this.
  • dialog appears to apply a default inset-block-start: probably will need to change the default when in fullscreen mode.

Workaround until fixed which I believe should work:

md-dialog[showing-fullscreen] {
  /* hack: private! */
  --_container-max-block-size: 100dvh;
  --md-dialog-container-inset-block-start: 0px;
}

@rbjarnason
Copy link
Author

Workaround works perfectly, thanks! :) Will remove hack after this gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment